Shorten read, user add, badblocks, curl completions#7788
Merged
Conversation
faho
requested changes
Mar 8, 2021
Member
faho
left a comment
There was a problem hiding this comment.
Some nitpicks, I think the dangerous thing should be added, the rest are more of a question of taste.
| complete -c read -s c -l command -d "Initial contents of read buffer when reading interactively" -r | ||
| complete -c read -s S -l shell -d "Use syntax highlighting, tab completions and command termination suitable for entering shellscript code" | ||
| complete -c read -s s -l silent -d "Secure mode: mask characters at the command line (suitable for passwords)" | ||
| complete -c read -s S -l shell -d "Highlight syntax, complete tabs, terminate commands as in shellscript" |
Member
There was a problem hiding this comment.
This listing feels a bit awkward.
Maybe something like "read like the shell would"?
Member
|
Merged, thanks! |
96 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR shortens completions in:
Fixes: #6981