Skip to content

Indent line continuations#7694

Merged
krobelus merged 4 commits into
fish-shell:masterfrom
krobelus:indent-line-continuations
Feb 13, 2021
Merged

Indent line continuations#7694
krobelus merged 4 commits into
fish-shell:masterfrom
krobelus:indent-line-continuations

Conversation

@krobelus
Copy link
Copy Markdown
Contributor

@krobelus krobelus commented Feb 8, 2021

Similar to what fish_indent does. After typing "echo " and hitting return,
the cursor will be indented.

A possible annoyance is that when you have multiple indented lines

echo 1 \
    2 \
    3 \
    4 \

If you remove lines in the middle with Control-k, the lines below
the deleted one will start jumping around, as they are disconnected
from and reconnected to "echo".

TODOs:

  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@ridiculousfish
Copy link
Copy Markdown
Member

ridiculousfish commented Feb 10, 2021

Looks great! Nice tests!

Probably not necessary for the next commit, but this way feels more logical
Similar to what fish_indent does. After typing "echo \" and hitting return,
the cursor will be indented.

A possible annoyance is that when you have multiple indented lines

	echo 1 \
	    2 \
	    3 \
	    4 \

If you remove lines in the middle with Control-k, the lines below
the deleted one will start jumping around, as they are disconnected
from and reconnected to "echo".
@krobelus krobelus force-pushed the indent-line-continuations branch from 28127df to fb7db1d Compare February 13, 2021 07:14
@krobelus krobelus added this to the fish 3.2.0 milestone Feb 13, 2021
@krobelus
Copy link
Copy Markdown
Contributor Author

Thanks! I took another look, this should be good to go.

@krobelus krobelus merged commit 5b3a466 into fish-shell:master Feb 13, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants