Skip to content

Consistency-fix for word motions#7354

Merged
faho merged 3 commits into
fish-shell:masterfrom
sgrj:word-motion
Sep 27, 2020
Merged

Consistency-fix for word motions#7354
faho merged 3 commits into
fish-shell:masterfrom
sgrj:word-motion

Conversation

@sgrj
Copy link
Copy Markdown
Contributor

@sgrj sgrj commented Sep 27, 2020

Description

Make the behavior of word-movements more consistent when the cursor is on the last letter of a word.

Fixes issue #7353

The word motion tests were adapted so that the first (or last) caret character specifies the starting location of the cursor (before, the start was always the first (or last) character in the string).

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho added the bug Something that's not working as intended label Sep 27, 2020
@faho faho added this to the fish 3.2.0 milestone Sep 27, 2020
@faho faho merged commit ab2cb03 into fish-shell:master Sep 27, 2020
@faho
Copy link
Copy Markdown
Member

faho commented Sep 27, 2020

Seems alright, thanks, merged!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something that's not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants