__fish_prepend_sudo: Toggle "sudo" on multiple presses#7012
Merged
Conversation
At the moment calling __fish_prepend_sudo multiple times does not toggle sudo, and also unnecessarily uses the `-c` flag to `commandline` to see if the first token on the commandline is "sudo". This change removes the `-c` switch and also toggles "sudo" on multiple calls to __fish_prepend_sudo, while maintaining the cursor position and while maintaining any spaces between "sudo" and the next token on the commandline.
krobelus
reviewed
May 17, 2020
| commandline -C (math $cursor + 5) | ||
| else | ||
| commandline -r (string sub --start=6 (commandline -p)) | ||
| set -l new_cursor (math $cursor - 5) |
Contributor
There was a problem hiding this comment.
You can do the same with commandline -C -- (math $cursor - 5)
Contributor
Author
There was a problem hiding this comment.
Ah I can't believe I didn't think of this... any negative result of the math is being counted as an option to commandline that doesn't exist. Nice catch.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment calling __fish_prepend_sudo multiple times does not toggle
sudo, and also unnecessarily uses the
-cflag tocommandlineto see ifthe first token on the commandline is "sudo".
This change removes the
-cswitch and also toggles "sudo" on multiplecalls to __fish_prepend_sudo, while maintaining the cursor position and
while maintaining any spaces between "sudo" and the next token on the
commandline.
The additional logic around the new_cursor position is because the
cursor could be in the "sudo" during the toggle.
Description
Talk about your changes here.
Fixes issue #
TODOs: