Print debug categories, add examples for fish --debug#7007
Merged
Conversation
krobelus
reviewed
May 15, 2020
Contributor
krobelus
left a comment
There was a problem hiding this comment.
This is a really useful, especially to have examples!
Contributor
|
Seems good. I guess that most users should never need to use the debug option, but this is probably the most obvious place to add examples to. |
Contributor
Author
|
Since |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Personally I was most confused by the description of
fish --debug-categoriesand needed to look in the code to figure out it supported comma-separated values in addition to globs. Hopefully this rewording and some examples makes it easier for the next person.I also found it helpful to print out the enabled debug categories. Without this information it's hard to tell immediately that your
--debug-categoriesvalue is working as expected.