Remove read history, let history delete read search terms interactively#5904
Merged
Conversation
This was undocumented, not all that useful and potentially unwanted. In particular it means that things like mysql -p(read) will still keep the password in history. Also it allows us to simply implement asking for the history deletion term. See fish-shell#5791.
Member
|
Convinced me - let's do it. LGTM. If this proves controversial we can add it back as an opt-in, it ought not to be the default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes
builtin reads history, which is:mysql -p(read)before, with the intention that these not show up in the history)Then it uses
readinhistory deleteif no searchterms are given.An alternative would be to add a flag to
readto not keep history (read --incognitoorread --no-history?), or to readd the--mode-nameflag and expect that. I've not done so because I don't see the use in the read history, and I believe that the expectation usually is that it doesn't keep history.Fixes issue #5791
TODOs: