Make "-q" always check for existence#5631
Merged
Merged
Conversation
Used to query for a builtin's existence, like `type -q` and `functions -q` can be used to query for a things and a functions existence respectively.
This required "-sq" to be used and errored if just "-q" was given. Instead, if only "-q" is given, we behave just as if "-sq" was.
Member
|
Seems fine to me, remember to relnote it |
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently I had the weird experience of having to explain to someone how to check if a thing-you-can-call exists (i.e. a function, builtin, command, or any of them).
And what I had to say was:
It seems to be a fairly straightforward improvement to usability to just add a "-q" option to all of these.
So this PR adds "-q"/"--query" to
builtinand allowscommand -q $thingto work by making "-q" imply "-s".For historical reasons the long form to "command" is still "--quiet", but that's not a large problem.
TODOs: