Fix overzealous cd tab completion#4649
Closed
mtbrock wants to merge 1 commit into
Closed
Conversation
Changed cd completion to differentiate between cd autosuggest and cd tab completion. cd autosuggest will find deepest unique hierarchy and cd tab completion will not. Issue fish-shell#4402
Member
|
Looks really good! I'll test and then merge if it checks out. Thanks for doing this! |
Member
|
Merged as bf63e06, thanks! |
ridiculousfish
added a commit
that referenced
this pull request
Jan 9, 2018
Contributor
Author
|
Glad I could help |
|
Actually I loved this feature. Is it possible to have this as a feature flag? |
Member
|
Not suitable for a feature flag, but this might be writable as a custom completion if someone wants to try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed cd completion to differentiate between cd autosuggest and cd tab
completion. cd autosuggest will find deepest unique hierarchy and cd tab
completion will not.
Fixes issue #4402
TODOs: