Add completions for mdadm#4198
Merged
Merged
Conversation
faho
requested changes
Jul 7, 2017
| # as their absence has already been checked, because this absence caused evaluation of __fish_not_contain_opt | ||
|
|
||
| function __fish_mdadm_metadata_options | ||
| echo "0 Use original 0.90 format superblock" |
Member
There was a problem hiding this comment.
Are these literal tab characters?
I'd prefer it if we used the \t escape instead.
It's even possible to use something like
printf '%s\t%s\n' "0" "Use original 0.90 format superblock" \
"0.90" "Use original 0.90 format superblock"
# and so on
Member
There was a problem hiding this comment.
Or, a bit simpler:
echo "0"\t"Use original 0.90 format superblock"
echo "0.90"\t"..."or countless variations. Anyway, please use \t, no tab characters in our files if we can help it.
Contributor
Contributor
Author
|
Here you are. |
Member
|
And there you are - merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds completions for
mdadm, the Linux tool for maintaining software RAID. This has been developed using themanpage, so it should be rather exhaustive, taking into account around 98% of use cases AFAIK, but there could be some lacks due to:mdadmidiosyncrasies, like using the same short option for several long ones, or their different meanings in different contexts,man, being only a regularmdadmuser, not an expert,TODOs: