Skip to content

fish_config prompt rendering is wrong #2924

@floam

Description

@floam

Consider the preview for the Terlar theme:

screenshot 2016-04-09 at 10 14 11 pm

On my terminal it actually renders like this:

screenshot 2016-04-09 at 10 11 04 pm

There are issues:

  1. For certain glyphs like that lightning bolt, the webapp isn't picking the glyphs we'd like see at the terminal.
  2. There is some bug with the colors likely not changing/ending the way they actually do in a terminal (color of the second line).
  3. All of the git-aware commands only have an indication and preview of their true nature if you happen to execute them in a git repo.

A PR for 1 is incoming. 2 is caused because that color changes depending on exit status... and for some reason that's always not 0 in the demonstrations I guess.

After looking over how these are rendered, I wonder if fish wouldn't be better off using a Javascript module that is capable of more accurately and fully rendering a string full of ANSI/vt100 escape sequences the same way a terminal would. It would be neat to show color schemes and the prompt together, by feeding something like tty.js actual fish output.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementrelease notesSomething that is or should be mentioned in the release notes

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions