illumos support#12410
Conversation
|
Lmk if I should add tests and/or changes to the change log |
|
@krobelus What would you like me to do for casting flags? I made it more concise but now clippy is failing. I think a clippy ignore is probably a bad solution here. From my understanding, the only real solution is going to be the original version (cfg_if) with some duplication. |
|
We use |
|
I think we should just remove the type annotation on let mut flags = 0;
flags |= libc::POSIX_SPAWN_SETSIGDEF;
flags |= libc::POSIX_SPAWN_SETSIGMASK;
if desired_pgid.is_some() {
flags |= libc::POSIX_SPAWN_SETPGROUP;
}
attr.set_flags(flags.try_into().expect("Flags should fit in c_short"))?; |
|
3. Just remove the type annotation on `flags` (I think this is the best)
Yeah. Great work.
|
|
Added. Lmk if you want any changes. Otherwise, should be good to merge. |
|
merged, I only added a refactoring in dadec16 (path_remoteness: use cfg_if, 2026-02-08)
|
Added fixes to support illumos. Closes issue #11099