Fix webconfig#11861
Closed
milouse wants to merge 2 commits into
Closed
Conversation
Underline is no more a boolean and should be one of the accepted style, or None. By keeping False as default value, web_config was generating wrong --underline=False settings
krobelus
pushed a commit
that referenced
this pull request
Oct 3, 2025
Underline is no more a boolean and should be one of the accepted style, or None. By keeping False as default value, web_config was generating wrong --underline=False settings Part of #11861
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not sure since when, but I just used web_config to refresh my color theme and discovered that it generates some error as universal values.
This MR fix the 2 issues I got:
--underline=False, which makes set_color not really happy--background=redinstead of--background red), causing the = sign to be kept as part of the color value, leading after translation to universal variable to a wrong double = sign:--background==red.Fixes issue #
TODOs: