Try to enable 24-bit RGB colors by default#11372
Closed
krobelus wants to merge 2 commits into
Closed
Conversation
Member
|
So this does querying, which I think is overkill for this and I'm not a fan of. I think we can just assume no COLORTERM is a misconfiguration (or ssh's mistake) and assume RGB-color is supported. |
59b7510 to
b0cf678
Compare
b0cf678 to
d8576b9
Compare
faho
reviewed
Apr 11, 2025
| "disabled" | ||
| } | ||
| ); | ||
| } else if vars.get(L!("STY")).is_some() || term.starts_with(L!("eterm")) { |
Member
There was a problem hiding this comment.
Screen won't unset $COLORTERM, so STY should stay.
I think `set_color ff0000` should default to outputting true-color sequences. Unfortunately there is no good and widely-supported way to query for true-color support. `COLORTERM=truecolor` doesn't work in some cases such as ssh. Since many terminals nowadays implement the RGB sequences, let's try using them by default. Note that Emacs's ansi-term implements truecolor now. See also the discussion around fish-shell#11345 (comment)
d8576b9 to
c8aa313
Compare
faho
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COLORTERM=truecolordoesn't work in some cases; I think we may want toeither default to assuming truecolor is supported, or use this recommended
fix.
See the discussion around
#11345 (comment)
TODO: docs
fish_term24bitdoc_src/cmds/set_color.rstdoc_src/terminal-compatibility.rst