fish_vi_cursor: Remove terminal checks#10693
Merged
Merged
Conversation
We keep having to extend these with new terminals, and I can no longer find a terminal that fails this. Even emacs' ansi-term can now at least reliably ignore the sequence.
krobelus
reviewed
Aug 30, 2024
| set varname fish_cursor_unknown | ||
| end | ||
| $function \$\$varname | ||
| __fish_cursor_xterm \$\$varname |
Contributor
There was a problem hiding this comment.
LGTM, the reason why I didn't remove these checks is simply that I didn't look into what the cursor control sequences look like.
Looks like they use CSI (and have a space in the middle, oddly) which we already send.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep having to extend these with new terminals, and I can no longer find a terminal that fails this.
Even emacs' ansi-term can now at least reliably ignore the sequence.
TODOs: