abbr: expand command abbrs after decorators#10396
Merged
Merged
Conversation
Currently, we expand command-abbrs (those with `--position command`) after `if`, but not after `command` or `builtin` or `time`: ```fish abbr --add gc "git checkout" ``` will expand as `if gc` but not as `command gc`. This was explicitly tested, but I have no idea why it shouldn't be?
Member
|
I think I considered |
ridiculousfish
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we expand command-abbrs (those with
--position command) afterif, but not aftercommandorbuiltinortime:will expand as
if gcbut not ascommand gc.This was explicitly tested, but I have no idea why it shouldn't be?
Looking at the git history nothing really springs up as explanation.
TODOs: