Skip to content

history: fix deleting last entry#10190

Merged
faho merged 1 commit into
fish-shell:masterfrom
NethumL:fix-history-delete
Jan 4, 2024
Merged

history: fix deleting last entry#10190
faho merged 1 commit into
fish-shell:masterfrom
NethumL:fix-history-delete

Conversation

@NethumL
Copy link
Copy Markdown
Contributor

@NethumL NethumL commented Jan 4, 2024

Description

Handles trying to delete the last history entry correctly (full explanation on issue description).

Fixes issue #10189

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho
Copy link
Copy Markdown
Member

faho commented Jan 4, 2024

Yup, cool, thanks!

For next time: When you already have a patch for what is a clear bug, just skip the issue and put everything in the PR.

There's no real use to it other than forcing me to click "close" twice.

@faho faho added the bug Something that's not working as intended label Jan 4, 2024
@faho faho added this to the fish next-3.x milestone Jan 4, 2024
@faho faho modified the milestones: fish next-3.x, fish 3.7.1 Jan 20, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something that's not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants