chore: refactor for easy subclassing and new features#8514
Merged
Conversation
vtrifonov
approved these changes
Apr 10, 2020
vtrifonov
approved these changes
Apr 10, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring in the sense that now the intelligence of the
UITextFieldDelegateis in theTextFieldclass.This is a really nice addition for plugin developers like me.
For example in
nativescript-material-textfieldi wanted to add a feature to limit digits that a textfield can accept.This has to be handled in the delegate. Right now i have to rewrite and duplicate the whole delegate code from {N} to keep the feature of the {N} Textfield. It also means maintaining the delegate through {N} updates.
This makes it possible to simply "override" the delegate methods from your subclass of
TextFieldThe only unknown there is, should those delegate functions be added in the typings