Skip to content

feat(utils): work openFile in simulator#8495

Merged
vtrifonov merged 6 commits into
NativeScript:masterfrom
tarunama:feat/open-file-in-simulator
Apr 3, 2020
Merged

feat(utils): work openFile in simulator#8495
vtrifonov merged 6 commits into
NativeScript:masterfrom
tarunama:feat/open-file-in-simulator

Conversation

@tarunama

@tarunama tarunama commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

can not open file in iOS simulator.

What is the new behavior?

can open file in iOS simulator

Implements #8410

@cla-bot

cla-bot Bot commented Apr 2, 2020

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Takuya Yamamoto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
@cla-bot

cla-bot Bot commented Apr 2, 2020

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Takuya Yamamoto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@tarunama tarunama force-pushed the feat/open-file-in-simulator branch from dbc796c to a57847a Compare April 3, 2020 02:40
@cla-bot

cla-bot Bot commented Apr 3, 2020

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Takuya Yamamoto.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@tarunama tarunama force-pushed the feat/open-file-in-simulator branch from a57847a to 4bf7f3f Compare April 3, 2020 02:56
@cla-bot cla-bot Bot added the cla: yes label Apr 3, 2020
@vtrifonov

vtrifonov commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

@tarunama can you please merge the following PR to your branch first tarunama#1

@tarunama tarunama force-pushed the feat/open-file-in-simulator branch from e7efd4d to 4bf7f3f Compare April 3, 2020 10:08
@tarunama

tarunama commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

@vtrifonov
Thank you for your perfect following !

@vtrifonov

vtrifonov commented Apr 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@tarunama I don't see my changes though?

@tarunama

tarunama commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

@vtrifonov
Sorry, I mistake git command

@vtrifonov
feat: have in mind isRealDevice in utils.openFile
8cb95bf 
refactor to avoid some circular dependencies
@vtrifonov

vtrifonov commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

@tarunama one more PR to merge tarunama#2 :)

@vtrifonov vtrifonov merged commit bd9828a into NativeScript:master Apr 3, 2020
@tarunama tarunama deleted the feat/open-file-in-simulator branch April 3, 2020 22:24
NathanWalker pushed a commit that referenced this pull request Aug 7, 2020
@tarunama @vtrifonov @NathanWalker
feat(utils): work openFile in simulator (#8495)
26df46e 
* feat: open file in iOS simulator

* feat: added isRealDevice util

* feat: have in mind isRealDevice in utils.openFile

refactor to avoid some circular dependencies

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
NathanWalker pushed a commit that referenced this pull request Aug 7, 2020
@tarunama @vtrifonov @NathanWalker
feat(utils): work openFile in simulator (#8495)
4e314f8 
* feat: open file in iOS simulator

* feat: added isRealDevice util

* feat: have in mind isRealDevice in utils.openFile

refactor to avoid some circular dependencies

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vtrifonov vtrifonov vtrifonov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarunama @vtrifonov