fix: dont create an actionbar if not necessary#8402
Merged
vtrifonov merged 4 commits intoMar 19, 2020
Conversation
For now i kept the commented code so that you can see the change. Also i changed the android check to behave like iOS
Contributor
|
Hey @farfromrefug - this is kind of a breaking change as in Android you get an ActionBar with the name of the app by default. With your PR it is hidden by default. You can see the change in the Screenshot from Screenshot from PR branch: |
Collaborator
Author
|
@vakrilov ok i thought it would be. I ll fix it ! |
784aac4 to
7da312c
Compare
Collaborator
Author
|
@vakrilov i improved it. |
Contributor
|
@farfromrefug would you update your branch, please! |
vtrifonov
approved these changes
Mar 19, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* fix: dont create an actionbar if not necessary For now i kept the commented code so that you can see the change. Also i changed the android check to behave like iOS * rollback. we now try an make sure the actionbar is created only if needed * actually we should check for false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also i changed the android check to behave like iOS