feat(text-field): add closeOnReturn property to avoid auto dismissing…#8347
Merged
Conversation
… input on return press
vmutafov
approved these changes
Mar 9, 2020
Contributor
|
Hey @MCurran16 ! Thank you for the PR! Could you please update the |
vmutafov
approved these changes
Mar 20, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
#8347) * feat(text-field): add closeOnReturn property to avoid auto dismissing input on return press * tslint * Update NS public api Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com> Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… input on return press
PR Checklist
What is the current behavior?
The text field is automatically calling
dismissSoftInput()on return pressed.What is the new behavior?
Based on a flag called
closeOnReturn, the text field will either calldismissSoftInput()or not. ThecloseOnReturnproperty is true by default so the current behavior for text fields does not change.Fixes/Implements/Closes #8287 .